Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: webrtc/voice_engine/channel.h

Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed more comments from Henrik. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.h
diff --git a/webrtc/voice_engine/channel.h b/webrtc/voice_engine/channel.h
index 398087eefb481a0cd96624b6b086c3d9c0acbe58..6d568c047c70a5064940dee744cdeb05a57627bc 100644
--- a/webrtc/voice_engine/channel.h
+++ b/webrtc/voice_engine/channel.h
@@ -51,6 +51,7 @@ class FileWrapper;
class ProcessThread;
class ReceiveStatistics;
class RemoteNtpTimeEstimator;
+class RtcEventLog;
class RTPPayloadRegistry;
class RtpReceiver;
class RTPReceiverAudio;
@@ -448,6 +449,11 @@ public:
// Disassociate a send channel if it was associated.
void DisassociateSendChannel(int channel_id);
+ // Sets an RtcEventLog object to enable logging of debug events in the Audio
+ // Coding Module. Calling this function with a nullptr is allowed and will
+ // stop all logging activity.
+ void SetEventLog(RtcEventLog* event_log);
Henrik Grunell WebRTC 2015/08/05 09:44:35 Use a separate function for disabling the logging.
Henrik Grunell WebRTC 2015/08/07 11:30:03 Please address this.
terelius 2015/08/11 09:04:34 The main way to stop logging is to call StopLoggin
Henrik Grunell WebRTC 2015/08/12 12:38:50 OK, well, the comment says differently. :) We need
ivoc 2015/08/12 13:16:41 The SetEventLog function is removed in the latest
Henrik Grunell WebRTC 2015/08/12 15:29:53 Acknowledged.
+
protected:
void OnIncomingFractionLoss(int fraction_lost);

Powered by Google App Engine
This is Rietveld 408576698