Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1267463002: Add a frame generator that allows scrolling images (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a frame generator that allows scrolling over a larger still image, for use with new screen sharing quality tests. BUG= Committed: https://crrev.com/d63589579a66df028efe7ec63cf465082f3857fa Cr-Commit-Position: refs/heads/master@{#9654}

Patch Set 1 #

Patch Set 2 : Fixed casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -5 lines) Patch
M webrtc/test/frame_generator.h View 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 3 chunks +127 lines, -0 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 4 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sprang_webrtc
5 years, 4 months ago (2015-07-29 12:13:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267463002/20001
5 years, 4 months ago (2015-07-29 12:13:12 UTC) #4
pbos-webrtc
lgtm
5 years, 4 months ago (2015-07-29 12:19:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android/builds/7007)
5 years, 4 months ago (2015-07-29 13:03:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267463002/20001
5 years, 4 months ago (2015-07-29 13:54:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 14:58:18 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 14:58:26 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d63589579a66df028efe7ec63cf465082f3857fa
Cr-Commit-Position: refs/heads/master@{#9654}

Powered by Google App Engine
This is Rietveld 408576698