Pass the encoder's internal source property through to video_sender to request a keyframe from the e

Pass the encoder's internal source property through to video_sender to request a keyframe from the external encoder

BUG=

Committed: https://crrev.com/47d78cc8ad54baabc9042c2b848ae3afd9b80d2e
Cr-Commit-Position: refs/heads/master@{#9853}

[sophiechang-webrtc, 2015-07-31 00:14:21]

sophiechang@chromium.org changed reviewers:
+ noahric@chromium.org, pbos@webrtc.org

[pbos-webrtc, 2015-08-25 14:00:44]

Sorry for the slow response, I've been OOO for three weeks.

Should this instead be a property on the VideoEncoder instance or is this a
temporary solution for something we want to remove?

https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:175:
config.encoder_settings..internal_source));
s/.././?

[sophiechang-webrtc, 2015-08-25 14:52:58]

On 2015/08/25 14:00:44, pbos-webrtc wrote:
> Sorry for the slow response, I've been OOO for three weeks.
> 
> Should this instead be a property on the VideoEncoder instance or is this a
> temporary solution for something we want to remove?
> 
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> File webrtc/video/video_send_stream.cc (right):
> 
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> webrtc/video/video_send_stream.cc:175:
> config.encoder_settings..internal_source));
> s/.././?

This is pretty much a temporary solution.  Noah would know more, but we
currently need this to be able to work with our current hw encoder
implementations. I believe the plan is to change our encoding strategy at some
point so we don't need the internal source flag anymore.

[pbos-webrtc, 2015-08-25 15:43:49]

On 2015/08/25 14:52:58, sophiechang-webrtc wrote:
> On 2015/08/25 14:00:44, pbos-webrtc wrote:
> > Sorry for the slow response, I've been OOO for three weeks.
> > 
> > Should this instead be a property on the VideoEncoder instance or is this a
> > temporary solution for something we want to remove?
> > 
> >
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> > File webrtc/video/video_send_stream.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> > webrtc/video/video_send_stream.cc:175:
> > config.encoder_settings..internal_source));
> > s/.././?
> 
> This is pretty much a temporary solution.  Noah would know more, but we
> currently need this to be able to work with our current hw encoder
> implementations. I believe the plan is to change our encoding strategy at some
> point so we don't need the internal source flag anymore.

sgtm, can you make sure the code compiles and run the trybots?

[sophiechang-webrtc, 2015-08-25 16:01:57]

On 2015/08/25 15:43:49, pbos-webrtc wrote:
> On 2015/08/25 14:52:58, sophiechang-webrtc wrote:
> > On 2015/08/25 14:00:44, pbos-webrtc wrote:
> > > Sorry for the slow response, I've been OOO for three weeks.
> > > 
> > > Should this instead be a property on the VideoEncoder instance or is this
a
> > > temporary solution for something we want to remove?
> > > 
> > >
> >
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> > > File webrtc/video/video_send_stream.cc (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/1263663005/diff/1/webrtc/video/video_send_strea...
> > > webrtc/video/video_send_stream.cc:175:
> > > config.encoder_settings..internal_source));
> > > s/.././?
> > 
> > This is pretty much a temporary solution.  Noah would know more, but we
> > currently need this to be able to work with our current hw encoder
> > implementations. I believe the plan is to change our encoding strategy at
some
> > point so we don't need the internal source flag anymore.
> 
> sgtm, can you make sure the code compiles and run the trybots?

done.

[pbos-webrtc, 2015-08-25 16:09:31]

thx, lgtm

[sophiechang-webrtc, 2015-08-25 17:14:01]

sophiechang@chromium.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2015-09-03 11:48:25]

LGTM

Sorry for the late reply, slowly working through my review backlog.

[noahric, 2015-09-03 18:25:35]

The CQ bit was checked by noahric@chromium.org

[commit-bot: I haz the power, 2015-09-03 18:25:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263663005/20001

[commit-bot: I haz the power, 2015-09-03 20:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 20:26:03]

Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[noahric, 2015-09-03 20:26:48]

The CQ bit was checked by noahric@chromium.org

[commit-bot: I haz the power, 2015-09-03 20:27:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263663005/20001

[commit-bot: I haz the power, 2015-09-03 22:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 22:27:17]

Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[noahric, 2015-09-03 22:49:33]

The CQ bit was checked by noahric@chromium.org

[commit-bot: I haz the power, 2015-09-03 22:49:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263663005/20001

[commit-bot: I haz the power, 2015-09-04 01:24:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-04 01:25:01]

Patchset 2 (id:??) landed as
https://crrev.com/47d78cc8ad54baabc9042c2b848ae3afd9b80d2e
Cr-Commit-Position: refs/heads/master@{#9853}