Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1262853003: Added IsInBeam to mock_nonlinear_beamformer.h (Closed)

Created:
5 years, 4 months ago by bloch
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added IsInBeam to mock_nonlinear_beamformer.h Committed: https://crrev.com/ee66016930ef7e2e6fda1e45bc2663fe98d08e20 Cr-Commit-Position: refs/heads/master@{#9655}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Added close paren #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bloch
This method is needed for dependency injection in a unittest.
5 years, 4 months ago (2015-07-29 23:05:23 UTC) #2
aluebs-webrtc
lgtm
5 years, 4 months ago (2015-07-29 23:11:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262853003/20001
5 years, 4 months ago (2015-07-29 23:14:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android/builds/7020) linux_baremetal on tryserver.webrtc (JOB_FAILED, ...
5 years, 4 months ago (2015-07-29 23:16:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262853003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262853003/40001
5 years, 4 months ago (2015-07-29 23:42:59 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 00:24:38 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 00:24:52 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee66016930ef7e2e6fda1e45bc2663fe98d08e20
Cr-Commit-Position: refs/heads/master@{#9655}

Powered by Google App Engine
This is Rietveld 408576698