Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1262333002: Move audio_coding_module.gypi from main/acm2 to main/. (Closed)

Created:
5 years, 4 months ago by pbos-webrtc
Modified:
5 years, 4 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move audio_coding_module.gypi from main/acm2 to main/. Prevents presubmit failures when touching audio_coding_module.gypi due to source files being included from outside the gypi directory. BUG= R=minyue@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9a6e74179cc02daec9b93710e334b9035c525709

Patch Set 1 #

Patch Set 2 : sort #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -205 lines) Patch
M webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
A + webrtc/modules/audio_coding/main/audio_coding_module.gypi View 1 2 5 chunks +41 lines, -41 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pbos-webrtc
PTAL
5 years, 4 months ago (2015-07-30 09:06:05 UTC) #1
pbos-webrtc
sort
5 years, 4 months ago (2015-07-30 09:07:07 UTC) #2
minyue-webrtc
lgtm
5 years, 4 months ago (2015-07-30 09:07:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262333002/20001
5 years, 4 months ago (2015-07-30 09:07:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/4870) ios_arm64 on tryserver.webrtc (JOB_FAILED, ...
5 years, 4 months ago (2015-07-30 09:08:47 UTC) #7
pbos-webrtc
rebase
5 years, 4 months ago (2015-07-30 09:11:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262333002/40001
5 years, 4 months ago (2015-07-30 09:12:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/284)
5 years, 4 months ago (2015-07-30 09:14:24 UTC) #13
pbos-webrtc
5 years, 4 months ago (2015-07-30 09:34:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9a6e74179cc02daec9b93710e334b9035c525709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698