Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1262153003: Use RtcpPacket to send PLI in RtcpSender (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 5 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sprang_webrtc
5 years, 4 months ago (2015-07-29 15:38:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262153003/1
5 years, 4 months ago (2015-07-29 15:38:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 16:30:53 UTC) #8
åsapersson
lgtm https://codereview.webrtc.org/1262153003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1262153003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode127 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:127: this); nit: remove extra space
5 years, 4 months ago (2015-07-31 13:36:42 UTC) #9
sprang_webrtc
https://codereview.webrtc.org/1262153003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right): https://codereview.webrtc.org/1262153003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc#newcode127 webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:127: this); On 2015/07/31 13:36:42, asapersson wrote: > nit: remove ...
5 years, 4 months ago (2015-07-31 14:15:53 UTC) #10
sprang_webrtc
5 years, 4 months ago (2015-07-31 14:16:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72aa9a6c6e8d05c744496ad8c53273ec49556d28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698