Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1260183004: VideoCapturerAndroid: Check if data is null in onPreviewFrame() (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Check if data is null in onPreviewFrame() onPreviewFrame() might be called with a null data pointer, which is allowed according to the documentation. BUG=webrtc:4877 Committed: https://crrev.com/37ec7330b4eff1da0f756fc9ac966d25cbc0fce7 Cr-Commit-Position: refs/heads/master@{#9674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183004/1
5 years, 4 months ago (2015-08-04 11:29:21 UTC) #2
tommi
lgtm
5 years, 4 months ago (2015-08-04 12:32:01 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 13:29:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183004/1
5 years, 4 months ago (2015-08-04 13:30:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 15:30:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183004/1
5 years, 4 months ago (2015-08-04 15:53:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 17:53:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183004/1
5 years, 4 months ago (2015-08-05 07:32:58 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 07:34:58 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 07:35:05 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/37ec7330b4eff1da0f756fc9ac966d25cbc0fce7
Cr-Commit-Position: refs/heads/master@{#9674}

Powered by Google App Engine
This is Rietveld 408576698