Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259683003: Includes webrtc/build/protoc.gypi instead of build/protoc.gypi (Closed)

Created:
5 years, 4 months ago by terelius
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, kwiberg-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Includes webrtc/build/protoc.gypi instead of build/protoc.gypi Re-lands "Renamed the ACMDump to RtcEventLog and moved it to webrtc/video, since it is not specific to the audio coding module." This reverts commit b933667a7f97697d6390d1eee5f378cedd9ca208. R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/364118518fda145434e9405b619749e8f2ff70c7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1235 lines, -657 lines) Patch
M webrtc/BUILD.gn View 4 chunks +41 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +0 lines, -30 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/dump.proto View 1 chunk +0 lines, -169 lines 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/video/rtc_event_log.h View 1 chunk +81 lines, -0 lines 0 comments Download
A webrtc/video/rtc_event_log.cc View 1 chunk +406 lines, -0 lines 0 comments Download
A webrtc/video/rtc_event_log.proto View 1 chunk +228 lines, -0 lines 0 comments Download
A webrtc/video/rtc_event_log_unittest.cc View 1 chunk +429 lines, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 3 chunks +37 lines, -0 lines 1 comment Download
M webrtc/webrtc_tests.gypi View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
5 years, 4 months ago (2015-07-30 10:35:03 UTC) #2
pbos-webrtc
rs-lgtm
5 years, 4 months ago (2015-07-30 10:38:04 UTC) #3
terelius
Committed patchset #1 (id:1) manually as 364118518fda145434e9405b619749e8f2ff70c7 (presubmit successful).
5 years, 4 months ago (2015-07-30 10:45:31 UTC) #4
kjellander_webrtc
5 years, 3 months ago (2015-09-15 13:26:33 UTC) #6
Message was sent while issue was closed. 
https://codereview.webrtc.org/1259683003/diff/1/webrtc/webrtc.gyp
File webrtc/webrtc.gyp (right):

https://codereview.webrtc.org/1259683003/diff/1/webrtc/webrtc.gyp#newcode112
webrtc/webrtc.gyp:112: 'target_name': 'rtc_event_log',
Putting this target here, combined with
https://codereview.webrtc.org/1267683002/ introduces more circular dependencies
to WebRTC, which something we would rather try to get rid of (see
https://code.google.com/p/webrtc/issues/detail?id=4243).

Is it maybe possible to move the rtc_event_log into webrtc/tools instead?

Powered by Google App Engine
This is Rietveld 408576698