Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1258803003: Revert "Add a frame generator that allows scrolling over a larger still image, for use with new scr… (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Add a frame generator that allows scrolling over a larger still image, for use with new screen sharing quality tests." This reverts commit 89934133988feaf14fb88f5258f727232a283d0f. BUG= R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/49c0ce359f82b41318e0f8c844db3dd6cba40159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -179 lines) Patch
M webrtc/test/frame_generator.h View 2 chunks +0 lines, -19 lines 0 comments Download
M webrtc/test/frame_generator.cc View 3 chunks +0 lines, -125 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 4 chunks +5 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258803003/1
5 years, 4 months ago (2015-07-29 12:05:43 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-29 12:05:45 UTC) #4
sprang_webrtc
5 years, 4 months ago (2015-07-29 12:05:50 UTC) #6
pbos-webrtc
On 2015/07/29 12:05:50, språng wrote: rof lgtm
5 years, 4 months ago (2015-07-29 12:06:08 UTC) #7
sprang_webrtc
5 years, 4 months ago (2015-07-29 12:07:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49c0ce359f82b41318e0f8c844db3dd6cba40159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698