Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: webrtc/modules/utility/source/process_thread_impl.cc

Issue 1257833004: Prevent TimeUntilNextProcess log spam. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/utility/source/process_thread_impl.h" 11 #include "webrtc/modules/utility/source/process_thread_impl.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 #include "webrtc/modules/interface/module.h" 14 #include "webrtc/modules/interface/module.h"
15 #include "webrtc/system_wrappers/interface/logging.h" 15 #include "webrtc/system_wrappers/interface/logging.h"
16 #include "webrtc/system_wrappers/interface/tick_util.h" 16 #include "webrtc/system_wrappers/interface/tick_util.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 namespace { 19 namespace {
20 20
21 // We use this constant internally to signal that a module has requested 21 // We use this constant internally to signal that a module has requested
22 // a callback right away. When this is set, no call to TimeUntilNextProcess 22 // a callback right away. When this is set, no call to TimeUntilNextProcess
23 // should be made, but Process() should be called directly. 23 // should be made, but Process() should be called directly.
24 const int64_t kCallProcessImmediately = -1; 24 const int64_t kCallProcessImmediately = -1;
25 25
26 int64_t GetNextCallbackTime(Module* module, int64_t time_now) { 26 int64_t GetNextCallbackTime(Module* module, int64_t time_now) {
27 int64_t interval = module->TimeUntilNextProcess(); 27 int64_t interval = module->TimeUntilNextProcess();
28 // Currently some implementations erroneously return error codes from
29 // TimeUntilNextProcess(). So, as is, we correct that and log an error.
30 if (interval < 0) { 28 if (interval < 0) {
31 LOG(LS_ERROR) << "TimeUntilNextProcess returned an invalid value " 29 // Falling behind, we should call the callback now.
32 << interval; 30 return time_now;
33 interval = 0;
34 } 31 }
35 return time_now + interval; 32 return time_now + interval;
36 } 33 }
37 } 34 }
38 35
39 ProcessThread::~ProcessThread() {} 36 ProcessThread::~ProcessThread() {}
40 37
41 // static 38 // static
42 rtc::scoped_ptr<ProcessThread> ProcessThread::Create() { 39 rtc::scoped_ptr<ProcessThread> ProcessThread::Create() {
43 return rtc::scoped_ptr<ProcessThread>(new ProcessThreadImpl()).Pass(); 40 return rtc::scoped_ptr<ProcessThread>(new ProcessThreadImpl()).Pass();
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 } 225 }
229 } 226 }
230 227
231 int64_t time_to_wait = next_checkpoint - TickTime::MillisecondTimestamp(); 228 int64_t time_to_wait = next_checkpoint - TickTime::MillisecondTimestamp();
232 if (time_to_wait > 0) 229 if (time_to_wait > 0)
233 wake_up_->Wait(static_cast<unsigned long>(time_to_wait)); 230 wake_up_->Wait(static_cast<unsigned long>(time_to_wait));
234 231
235 return true; 232 return true;
236 } 233 }
237 } // namespace webrtc 234 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698