Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1256803004: Control combined_audio_video_bwe with config bool. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Control combined_audio_video_bwe with config bool. Permits setting RTP extensions for AudioReceiveStream without enabling combined A/V BWE. This prevents spamming the log with "Failed to find extension id:". BUG=webrtc:4870 R=mflodman@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/6bb1b6e7fe5631e9f218b80292df5b64623c5616 Cr-Commit-Position: refs/heads/master@{#9633}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename -> SetCallConfiguresAudioReceiveChannels #

Total comments: 2

Patch Set 3 : default config combined_audio_video_bwe to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -34 lines) Patch
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 7 chunks +26 lines, -29 lines 0 comments Download
M webrtc/audio_receive_stream.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/audio_receive_stream.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/video/bitrate_estimator_tests.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-24 09:44:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256803004/1
5 years, 5 months ago (2015-07-24 09:44:38 UTC) #3
stefan-webrtc
lgtm https://codereview.webrtc.org/1256803004/diff/1/talk/media/webrtc/webrtcvoiceengine_unittest.cc File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right): https://codereview.webrtc.org/1256803004/diff/1/talk/media/webrtc/webrtcvoiceengine_unittest.cc#newcode3437 talk/media/webrtc/webrtcvoiceengine_unittest.cc:3437: TEST_F(WebRtcVoiceEngineTestFake, SetCall) { Rename
5 years, 5 months ago (2015-07-24 09:57:47 UTC) #4
pbos-webrtc
rename -> SetCallConfiguresAudioReceiveChannels
5 years, 5 months ago (2015-07-24 09:59:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256803004/20001
5 years, 5 months ago (2015-07-24 11:15:32 UTC) #7
mflodman
One comment, then LGTM. https://codereview.webrtc.org/1256803004/diff/20001/webrtc/audio_receive_stream.h File webrtc/audio_receive_stream.h (right): https://codereview.webrtc.org/1256803004/diff/20001/webrtc/audio_receive_stream.h#newcode64 webrtc/audio_receive_stream.h:64: bool combined_audio_video_bwe = true; I'd ...
5 years, 5 months ago (2015-07-24 12:28:23 UTC) #8
stefan-webrtc
https://codereview.webrtc.org/1256803004/diff/20001/webrtc/audio_receive_stream.h File webrtc/audio_receive_stream.h (right): https://codereview.webrtc.org/1256803004/diff/20001/webrtc/audio_receive_stream.h#newcode64 webrtc/audio_receive_stream.h:64: bool combined_audio_video_bwe = true; On 2015/07/24 12:28:22, mflodman_OOO wrote: ...
5 years, 5 months ago (2015-07-24 12:35:10 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 12:37:38 UTC) #11
pbos-webrtc
default config combined_audio_video_bwe to false
5 years, 5 months ago (2015-07-24 12:39:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256803004/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256803004/30001
5 years, 5 months ago (2015-07-24 12:40:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 5 months ago (2015-07-24 14:10:23 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 14:10:36 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6bb1b6e7fe5631e9f218b80292df5b64623c5616
Cr-Commit-Position: refs/heads/master@{#9633}

Powered by Google App Engine
This is Rietveld 408576698