Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: webrtc/system_wrappers/source/trace_impl.cc

Issue 1256773002: When we trace to file, add eol of each trace message. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/system_wrappers/source/trace_impl.cc
diff --git a/webrtc/system_wrappers/source/trace_impl.cc b/webrtc/system_wrappers/source/trace_impl.cc
index 25da5a0c9ac61ee9fd718fc863b705ae7b16a815..9234ffa3d9762900815edab515baa787d63d7e73 100644
--- a/webrtc/system_wrappers/source/trace_impl.cc
+++ b/webrtc/system_wrappers/source/trace_impl.cc
@@ -448,6 +448,8 @@ void TraceImpl::AddImpl(const TraceLevel level,
return;
ack_len += len;
+ trace_message[ack_len] = 0;
+ trace_message[ack_len - 1] = '\n';
pbos-webrtc 2015/07/24 08:29:11 Doesn't this truncate the last character?
braveyao1 2015/07/24 10:02:39 I was afraid so. But magically it doesn't. It's eq
AddMessageToList(trace_message, static_cast<uint16_t>(ack_len), level);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698