Chromium Code Reviews

Issue 1256713004: Add a scrolling frame generator and use it in loopback test (Closed)

Created:
5 years, 5 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a frame generator that allows scrolling over a larger still image, for use with new screen sharing quality tests. Also add support for this in the loopback tests. BUG= R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/89934133988feaf14fb88f5258f727232a283d0f

Patch Set 1 #

Patch Set 2 : Formatting #

Total comments: 2

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Stats (+179 lines, -5 lines)
M webrtc/test/frame_generator.h View 2 chunks +19 lines, -0 lines 0 comments
M webrtc/test/frame_generator.cc View 3 chunks +125 lines, -0 lines 0 comments
M webrtc/video/screenshare_loopback.cc View 4 chunks +35 lines, -5 lines 0 comments

Messages

Total messages: 7 (1 generated)
sprang_webrtc
5 years, 5 months ago (2015-07-24 13:35:07 UTC) #2
pbos-webrtc
https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h File webrtc/test/frame_generator.h (right): https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h#newcode43 webrtc/test/frame_generator.h:43: static FrameGenerator* CreateScrollerFromYuvFiles( Comment what this "scroller" is supposed ...
5 years, 4 months ago (2015-07-27 13:28:16 UTC) #3
pbos-webrtc
On 2015/07/27 13:28:16, pbos-webrtc wrote: > https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h > File webrtc/test/frame_generator.h (right): > > https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h#newcode43 > ...
5 years, 4 months ago (2015-07-27 13:28:43 UTC) #4
sprang_webrtc
https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h File webrtc/test/frame_generator.h (right): https://codereview.webrtc.org/1256713004/diff/20001/webrtc/test/frame_generator.h#newcode43 webrtc/test/frame_generator.h:43: static FrameGenerator* CreateScrollerFromYuvFiles( On 2015/07/27 13:28:16, pbos-webrtc wrote: > ...
5 years, 4 months ago (2015-07-29 11:49:19 UTC) #5
pbos-webrtc
lgtm, I trust you! :)
5 years, 4 months ago (2015-07-29 11:51:31 UTC) #6
sprang_webrtc
5 years, 4 months ago (2015-07-29 11:54:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
89934133988feaf14fb88f5258f727232a283d0f (presubmit successful).

Powered by Google App Engine