Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1255883005:
Moved project configs to infra/config branch (Closed)
|
Created:
5 years, 4 months ago by nodir Modified:
5 years, 4 months ago Reviewers:
magjed_webrtc, kjellander_chromium, Paweł Hajdan Jr., kjellander_webrtc, Michael Achenbach CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc/@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMoved project configs to infra/config branch
luci-config has been switched to read from
https://chromium.googlesource.com/external/webrtc/+/infra/config
R=machenbach@chromium.org, phajdan.jr@chromium.org,
kjellander@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513460
Committed: https://crrev.com/eb04d687d3bd8d4c7cbe9eb00f0b8c77a873b428
Cr-Commit-Position: refs/heads/master@{#9689}
Patch Set 1 #
Messages
Total messages: 25 (8 generated)
nodir@chromium.org changed reviewers: + kjellander@chromium.org
PTAL
LGTM
LGTM
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
machenbach@chromium.org changed reviewers: + magjed@webrtc.org
+ owners
ping owners
On 2015/08/05 00:08:34, nodir wrote: > ping owners lgtm, assuming the other files are identical (it looked like it when I compared)
On 2015/08/07 08:00:29, kjellander (OOO until Sep 1) wrote: > On 2015/08/05 00:08:34, nodir wrote: > > ping owners > > lgtm, assuming the other files are identical (it looked like it when I compared) Question: infra/config should be left in place for the CQ config for now?
On 2015/08/07 08:01:22, kjellander (OOO until Sep 1) wrote: > On 2015/08/07 08:00:29, kjellander (OOO until Sep 1) wrote: > > On 2015/08/05 00:08:34, nodir wrote: > > > ping owners > > > > lgtm, assuming the other files are identical (it looked like it when I > compared) > > Question: infra/config should be left in place for the CQ config for now? yes, except not "for now". cq.cfg is supposed to remain in master branch
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Ah, wrong account. LGTM!
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1255883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1255883005/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eb04d687d3bd8d4c7cbe9eb00f0b8c77a873b428 Cr-Commit-Position: refs/heads/master@{#9689}
Message was sent while issue was closed.
Thank you! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
