Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1254723006: Ignore packets with reordered timestamps when doing BWE. (Closed)

Created:
5 years, 5 months ago by stefan-webrtc
Modified:
5 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore packets with reordered timestamps when doing BWE. BUG=webrtc:4793 Committed: https://crrev.com/cfd5f96307c278bc73a70865034704410e1e4b3b Cr-Commit-Position: refs/heads/master@{#9632}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/modules/remote_bitrate_estimator/inter_arrival.cc View 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
stefan-webrtc
5 years, 5 months ago (2015-07-24 08:43:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723006/1
5 years, 5 months ago (2015-07-24 08:44:00 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-24 08:44:01 UTC) #6
pbos-webrtc
lgtm, please fix my comment :) https://codereview.webrtc.org/1254723006/diff/1/webrtc/modules/remote_bitrate_estimator/inter_arrival.cc File webrtc/modules/remote_bitrate_estimator/inter_arrival.cc (right): https://codereview.webrtc.org/1254723006/diff/1/webrtc/modules/remote_bitrate_estimator/inter_arrival.cc#newcode64 webrtc/modules/remote_bitrate_estimator/inter_arrival.cc:64: assert(*arrival_time_delta_ms >= 0); ...
5 years, 5 months ago (2015-07-24 09:04:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723006/1
5 years, 5 months ago (2015-07-24 09:13:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 10:26:51 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 10:27:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfd5f96307c278bc73a70865034704410e1e4b3b
Cr-Commit-Position: refs/heads/master@{#9632}

Powered by Google App Engine
This is Rietveld 408576698