BWE Simulation Framework: Standard plot logging

webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc

Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
index fc6f01ebc7c94dde32b1d9db78bfd34e5bd6e0aa..4aa222137d2cadaa6672ecfdec334d9b0fe52ff2 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc
@@ -268,14 +268,8 @@ RateCounterFilter::RateCounterFilter(PacketProcessorListener* listener,
     : PacketProcessor(listener, flow_ids, kRegular),
       packets_per_second_stats_(),
       kbps_stats_(),
-      name_(),
+      name_(std::string(name) + "_A"),  // All flow ids.

[stefan-webrtc, 2015/07/24 09:30:42]

I don't fully understand this. What if a RateCounterFilter is created only to
cover a subset of flows?

[magalhaesc, 2015/07/24 11:46:40]

Right, I didn't consider that.
Replaced back with all flow ids.

       start_plotting_time_ms_(0) {
-  std::stringstream ss;
-  ss << name << "_";
-  for (int flow_id : flow_ids) {
-    ss << flow_id << ",";
-  }
-  name_ = ss.str();
 }
 
 RateCounterFilter::RateCounterFilter(PacketProcessorListener* listener,
@@ -307,7 +301,7 @@ void RateCounterFilter::Plot(int64_t timestamp_ms) {
     plot_kbps = rate_counter_.bits_per_second() / 1000.0;
   }
   BWE_TEST_LOGGING_CONTEXT(name_.c_str());
-  BWE_TEST_LOGGING_PLOT(0, "Throughput_#1", timestamp_ms, plot_kbps);
+  BWE_TEST_LOGGING_PLOT(0, "Throughput_kbps#2", timestamp_ms, plot_kbps);

[stefan-webrtc, 2015/07/24 09:30:42]

Isn't #1 the bitrate axis and #2 the delay axis?

[magalhaesc, 2015/07/24 13:51:40]

Yes.
I was using d for delay, will go back to the standard:
-- 1 if the alignment is with the left axis.
-- 2 if the alignment is with the right axis.

   RTC_UNUSED(plot_kbps);
 }