webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc - Issue 1253473004: BWE Simulation Framework: Standard plot logging

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc

Issue 1253473004: BWE Simulation Framework: Standard plot logging (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added missing comma in python script Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc » ('j') | webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc

index 5790974dcd746548025fbcbda612361407304fa8..6d6e7b93f9d93a2b26865932dc404d2cc01dee05 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimators_test.cc

@@ -268,7 +268,7 @@ TEST_P(BweFeedbackTest, ConstantCapacity) {

AdaptiveVideoSource source(0, 30, 300, 0, 0);

PacedVideoSender sender(&uplink_, &source, GetParam());

ChokeFilter filter(&uplink_, 0);

- RateCounterFilter counter(&uplink_, 0, "receiver_input");

+ RateCounterFilter counter(&uplink_, 0, "Receiver");

PacketReceiver receiver(&uplink_, 0, GetParam(), false, false);

const int kCapacityKbps = 1000;

filter.set_capacity_kbps(kCapacityKbps);

@@ -282,7 +282,7 @@ TEST_P(BweFeedbackTest, Choke1000kbps500kbps1000kbps) {

AdaptiveVideoSource source(0, 30, 300, 0, 0);

PacedVideoSender sender(&uplink_, &source, GetParam());

ChokeFilter filter(&uplink_, 0);

- RateCounterFilter counter(&uplink_, 0, "receiver_input");

+ RateCounterFilter counter(&uplink_, 0, "Receiver");

PacketReceiver receiver(&uplink_, 0, GetParam(), false, false);

const int kHighCapacityKbps = 1000;

const int kLowCapacityKbps = 500;

@@ -302,7 +302,7 @@ TEST_P(BweFeedbackTest, Choke200kbps30kbps200kbps) {

AdaptiveVideoSource source(0, 30, 300, 0, 0);

PacedVideoSender sender(&uplink_, &source, GetParam());

ChokeFilter filter(&uplink_, 0);

- RateCounterFilter counter(&uplink_, 0, "receiver_input");

+ RateCounterFilter counter(&uplink_, 0, "Receiver");

PacketReceiver receiver(&uplink_, 0, GetParam(), false, false);

const int kHighCapacityKbps = 200;

const int kLowCapacityKbps = 30;

@@ -324,7 +324,7 @@ TEST_P(BweFeedbackTest, Verizon4gDownlinkTest) {

VideoSender sender(&uplink_, &source, GetParam());

RateCounterFilter counter1(&uplink_, 0, "sender_output");

TraceBasedDeliveryFilter filter(&uplink_, 0, "link_capacity");

- RateCounterFilter counter2(&uplink_, 0, "receiver_input");

+ RateCounterFilter counter2(&uplink_, 0, "Receiver");

PacketReceiver receiver(&uplink_, 0, GetParam(), false, false);

ASSERT_TRUE(filter.Init(test::ResourcePath("verizon4g-downlink", "rx")));

RunFor(22 * 60 * 1000);

@@ -339,7 +339,7 @@ TEST_P(BweFeedbackTest, GoogleWifiTrace3Mbps) {

RateCounterFilter counter1(&uplink_, 0, "sender_output");

TraceBasedDeliveryFilter filter(&uplink_, 0, "link_capacity");

filter.set_max_delay_ms(500);

- RateCounterFilter counter2(&uplink_, 0, "receiver_input");

+ RateCounterFilter counter2(&uplink_, 0, "Receiver");

PacketReceiver receiver(&uplink_, 0, GetParam(), false, false);

ASSERT_TRUE(filter.Init(test::ResourcePath("google-wifi-3mbps", "rx")));

RunFor(300 * 1000);