Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1252993003: Fix to "Removing AudioMixerStatusReceiver and ParticipantStatistics" (Closed)

Created:
5 years, 4 months ago by minyue-webrtc
Modified:
5 years, 4 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix to "Removing AudioMixerStatusReceiver and ParticipantStatistics" In https://codereview.webrtc.org/1216133004/ level_indicator.h/cc should be removed from GN as well, which was forgotten. BUG=webrtc:497 TBR=andrew@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/95b8718dc63362470dd4ebeb428d70cd6ed780e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
minyue-webrtc
Hi Andrew, I forgot GN. I think it is proper to TBR you.
5 years, 4 months ago (2015-07-28 09:27:47 UTC) #2
minyue-webrtc
Committed patchset #1 (id:1) manually as 95b8718dc63362470dd4ebeb428d70cd6ed780e2 (presubmit successful).
5 years, 4 months ago (2015-07-28 09:29:24 UTC) #3
Andrew MacDonald
5 years, 4 months ago (2015-07-28 17:20:01 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698