Split MoveReadPosition into Forward and Backward versions.

Split MoveReadPosition into Forward and Backward versions.

This makes the interface consistent in its use of size_t, and will
reduce casts in callers as they shift to size_t, e.g. this CL:
https://codereview.webrtc.org/1227203003/

Committed: https://crrev.com/d40af69278f867965fd10313f9c99f90266a9469
Cr-Commit-Position: refs/heads/master@{#9646}

[Andrew MacDonald, 2015-07-24 19:02:13]

andrew@webrtc.org changed reviewers:
+ pkasting@chromium.org

[Andrew MacDonald, 2015-07-24 19:06:39]

https://codereview.webrtc.org/1252943007/diff/1/webrtc/common_audio/audio_rin...
File webrtc/common_audio/audio_ring_buffer.cc (right):

https://codereview.webrtc.org/1252943007/diff/1/webrtc/common_audio/audio_rin...
webrtc/common_audio/audio_ring_buffer.cc:69: const size_t moved =
rtc::checked_cast<size_t>(
We already check this value below, so a checked cast isn't needed.

[Peter Kasting, 2015-07-27 20:23:37]

LGTM

https://codereview.webrtc.org/1252943007/diff/40001/webrtc/common_audio/audio...
File webrtc/common_audio/audio_ring_buffer.h (right):

https://codereview.webrtc.org/1252943007/diff/40001/webrtc/common_audio/audio...
webrtc/common_audio/audio_ring_buffer.h:41: // Move the read position. The
forward version advances the read pointer
Nit: Per the style guide, all the function comments in this file really should
be descriptive ("Moves") rather than imperative ("Move").

[Andrew MacDonald, 2015-07-28 07:11:06]

https://codereview.webrtc.org/1252943007/diff/40001/webrtc/common_audio/audio...
File webrtc/common_audio/audio_ring_buffer.h (right):

https://codereview.webrtc.org/1252943007/diff/40001/webrtc/common_audio/audio...
webrtc/common_audio/audio_ring_buffer.h:41: // Move the read position. The
forward version advances the read pointer
On 2015/07/27 20:23:37, Peter Kasting wrote:
> Nit: Per the style guide, all the function comments in this file really should
> be descriptive ("Moves") rather than imperative ("Move").

Good point. Done.

[Andrew MacDonald, 2015-07-28 07:11:15]

The CQ bit was checked by andrew@webrtc.org

[Andrew MacDonald, 2015-07-28 07:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.webrtc.org/1252943007/#ps60001 (title:
"Descriptive comments.")

[commit-bot: I haz the power, 2015-07-28 07:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252943007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252943007/60001

[commit-bot: I haz the power, 2015-07-28 07:53:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-28 07:53:11]

Patchset 4 (id:??) landed as
https://crrev.com/d40af69278f867965fd10313f9c99f90266a9469
Cr-Commit-Position: refs/heads/master@{#9646}