Remove base channel for video receivers.

Remove base channel for video receivers.

BUG=webrtc:1695
R=stefan@webrtc.org

Committed: https://crrev.com/d6fc47ea9585fa405d8617ccc0b7704d2c9e8a0a
Cr-Commit-Position: refs/heads/master@{#9624}

[pbos-webrtc, 2015-07-22 15:52:54]

PTAL, this was surprisingly easy.

Did we gradually remove things so that this was now easy or did I miss something
huge? Tune in to our show tomorrow, same time as always, to find out.

[pbos-webrtc, 2015-07-22 15:52:59]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 15:53:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251163002/1

[commit-bot: I haz the power, 2015-07-22 17:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 17:16:54]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/5880)

[pbos-webrtc, 2015-07-22 22:48:13]

fix data race

[pbos-webrtc, 2015-07-22 22:48:54]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 22:49:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251163002/20001

[commit-bot: I haz the power, 2015-07-23 00:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 00:49:18]

Dry run: Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2015-07-23 08:34:39]

Looks like a great CL, but what about splitting it up into getting rid of
default encoders in vie channel and getting rid of base channel? Easier to
review, safer, etc.

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel.cc (left):

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel.cc:175: #ifdef VIDEOCODEC_VP8
I don't fully understand how this is related to this CL? Is it just cleaning
away more stuff while you are at it? Maybe it would be good to make it two
separate CLs in that case.

[pbos-webrtc, 2015-07-23 08:51:10]

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel.cc (left):

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel.cc:175: #ifdef VIDEOCODEC_VP8
On 2015/07/23 08:34:38, stefan-webrtc (holmer) wrote:
> I don't fully understand how this is related to this CL? Is it just cleaning
> away more stuff while you are at it? Maybe it would be good to make it two
> separate CLs in that case.

All call sites (of CreateSendChannel and CreateReceiveChannel) had
disable_default_encoder == true, so this is actually dead code.

[stefan-webrtc, 2015-07-23 12:43:46]

lgtm assuming my comment is correct.

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel.cc (left):

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel.cc:175: #ifdef VIDEOCODEC_VP8
On 2015/07/23 08:51:09, pbos-webrtc wrote:
> On 2015/07/23 08:34:38, stefan-webrtc (holmer) wrote:
> > I don't fully understand how this is related to this CL? Is it just cleaning
> > away more stuff while you are at it? Maybe it would be good to make it two
> > separate CLs in that case.
> 
> All call sites (of CreateSendChannel and CreateReceiveChannel) had
> disable_default_encoder == true, so this is actually dead code.

Thanks

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel_group.cc (left):

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel_group.cc:305: if
(OtherChannelsUsingEncoder(channel_id)) {
Can this no longer be the case? I guess it's not supported by the new API, so it
should be safe to remove...

[pbos-webrtc, 2015-07-23 12:45:42]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-07-23 12:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1251163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1251163002/20001

[pbos-webrtc, 2015-07-23 12:46:06]

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
File webrtc/video_engine/vie_channel_group.cc (left):

https://codereview.webrtc.org/1251163002/diff/20001/webrtc/video_engine/vie_c...
webrtc/video_engine/vie_channel_group.cc:305: if
(OtherChannelsUsingEncoder(channel_id)) {
On 2015/07/23 12:43:46, stefan-webrtc (holmer) wrote:
> Can this no longer be the case? I guess it's not supported by the new API, so
it
> should be safe to remove...

Yep, exactly. :)

[commit-bot: I haz the power, 2015-07-23 13:58:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-23 13:58:45]

Patchset 2 (id:??) landed as
https://crrev.com/d6fc47ea9585fa405d8617ccc0b7704d2c9e8a0a
Cr-Commit-Position: refs/heads/master@{#9624}