Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1250593002: Remove unused overuse detection metric (capture jitter). (Closed)

Created:
5 years, 5 months ago by åsapersson
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 8

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -289 lines) Patch
M webrtc/video_engine/overuse_frame_detector.h View 4 chunks +4 lines, -65 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector.cc View 1 9 chunks +6 lines, -84 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector_unittest.cc View 1 14 chunks +52 lines, -140 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
åsapersson
5 years, 5 months ago (2015-07-21 11:53:49 UTC) #4
pbos-webrtc
lgtm https://codereview.webrtc.org/1250593002/diff/40001/webrtc/video_engine/overuse_frame_detector.cc File webrtc/video_engine/overuse_frame_detector.cc (right): https://codereview.webrtc.org/1250593002/diff/40001/webrtc/video_engine/overuse_frame_detector.cc#newcode283 webrtc/video_engine/overuse_frame_detector.cc:283: if (last_capture_time_ != 0) { remove {}s https://codereview.webrtc.org/1250593002/diff/40001/webrtc/video_engine/overuse_frame_detector.cc#newcode392 ...
5 years, 5 months ago (2015-07-21 18:14:10 UTC) #5
åsapersson
https://codereview.webrtc.org/1250593002/diff/40001/webrtc/video_engine/overuse_frame_detector.cc File webrtc/video_engine/overuse_frame_detector.cc (right): https://codereview.webrtc.org/1250593002/diff/40001/webrtc/video_engine/overuse_frame_detector.cc#newcode283 webrtc/video_engine/overuse_frame_detector.cc:283: if (last_capture_time_ != 0) { On 2015/07/21 18:14:09, pbos-webrtc ...
5 years, 5 months ago (2015-07-22 05:50:24 UTC) #6
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-01 12:16:08 UTC) #7
åsapersson
5 years, 3 months ago (2015-09-08 08:52:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as
746210f46d096cc5e5889e215affac2017b99922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698