Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1250513006: Remove webrtc::Config from ViEChannelGroup. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 4 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc::Config from ViEChannelGroup. Also removing webrtc/experiments.h which is no longer used. BUG=webrtc:1695 R=stefan@webrtc.org TBR=mflodman@webrtc.org Committed: https://crrev.com/ef35f069e739feaae16fdfcc815d7af5cb05e9ae Cr-Commit-Position: refs/heads/master@{#9642}

Patch Set 1 #

Patch Set 2 : remove experiment.h from build files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -60 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/experiments.h View 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 6 chunks +9 lines, -13 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/webrtc.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-23 14:57:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250513006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250513006/1
5 years, 5 months ago (2015-07-23 14:57:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/8837)
5 years, 5 months ago (2015-07-23 14:58:59 UTC) #5
pbos-webrtc
remove experiment.h from build files
5 years, 5 months ago (2015-07-24 08:20:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250513006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250513006/20001
5 years, 5 months ago (2015-07-24 08:20:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 09:52:15 UTC) #10
stefan-webrtc
lgtm
5 years, 4 months ago (2015-07-27 14:02:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250513006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250513006/20001
5 years, 4 months ago (2015-07-27 14:11:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-27 15:37:10 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 15:37:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef35f069e739feaae16fdfcc815d7af5cb05e9ae
Cr-Commit-Position: refs/heads/master@{#9642}

Powered by Google App Engine
This is Rietveld 408576698