Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250383003: Revert "Renamed the ACMDump to RtcEventLog and moved it to webrtc/video, since it is not specific t… (Closed)

Created:
5 years, 4 months ago by terelius
Modified:
5 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, kwiberg-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Renamed the ACMDump to RtcEventLog and moved it to webrtc/video, since it is not specific to the audio coding module. Updated .gyp and .gn files accordingly." This reverts commit c159b046d7a0086e45ae0f79c00a462f3fafd207. BUG= R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b933667a7f97697d6390d1eee5f378cedd9ca208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -1235 lines) Patch
M webrtc/BUILD.gn View 4 chunks +0 lines, -41 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +30 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump.h View 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump.cc View 1 chunk +240 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/acm_dump_unittest.cc View 1 chunk +124 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 1 chunk +32 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/main/acm2/dump.proto View 1 chunk +169 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/video/rtc_event_log.h View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/video/rtc_event_log.cc View 1 chunk +0 lines, -406 lines 0 comments Download
D webrtc/video/rtc_event_log.proto View 1 chunk +0 lines, -228 lines 0 comments Download
D webrtc/video/rtc_event_log_unittest.cc View 1 chunk +0 lines, -429 lines 0 comments Download
M webrtc/webrtc.gyp View 3 chunks +0 lines, -37 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
terelius
5 years, 4 months ago (2015-07-30 10:03:09 UTC) #2
stefan-webrtc
lgtm
5 years, 4 months ago (2015-07-30 10:04:41 UTC) #3
terelius
5 years, 4 months ago (2015-07-30 10:05:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b933667a7f97697d6390d1eee5f378cedd9ca208.

Powered by Google App Engine
This is Rietveld 408576698