Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1250203002: Add encode and decode time to histograms stats: (Closed)

Created:
5 years, 5 months ago by åsapersson
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add encode and decode time to histograms stats: - "WebRTC.Video.EncodeTimeInMs" - "WebRTC.Video.DecodeTimeInMs" BUG=chromium:488243 Committed: https://crrev.com/6718e97e730dfeb0c4290128b5682e123dd75866 Cr-Commit-Position: refs/heads/master@{#9630}

Patch Set 1 : #

Patch Set 2 : remove histogram for process time #

Patch Set 3 : change to use DecoderTiming callback and added separate OnEncodedFrame callback to stats proxy #

Patch Set 4 : #

Patch Set 5 : added todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 4 4 chunks +10 lines, -1 line 0 comments Download
M webrtc/video/video_capture_input.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
åsapersson
5 years, 5 months ago (2015-07-23 10:52:52 UTC) #8
åsapersson
On 2015/07/23 10:52:52, asapersson wrote: Updated according to offline discussion, ptal.
5 years, 5 months ago (2015-07-23 12:44:11 UTC) #9
pbos-webrtc
lgtm
5 years, 5 months ago (2015-07-23 12:53:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1250203002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1250203002/190001
5 years, 5 months ago (2015-07-24 07:20:26 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:190001)
5 years, 5 months ago (2015-07-24 07:21:02 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 07:21:14 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6718e97e730dfeb0c4290128b5682e123dd75866
Cr-Commit-Position: refs/heads/master@{#9630}

Powered by Google App Engine
This is Rietveld 408576698