Issue 1249573002: Fix the problom that on Linux no external audio device can be selected since #9243.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1249573002: Fix the problom that on Linux no external audio device can be selected since #9243. (Closed)

Created:
5 years, 5 months ago by braveyao1

Modified:
5 years, 4 months ago

Reviewers:
henrika_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Fix the problom that on Linux no external audio device can be selected since #9243. In #9243 we added some thread_checker. But it shouldn't be added into PlayoutDevices() and RecordingDevices(), since these two will be invoked from RecThread and PlayoutThread too, other than the main thread. BUG=webrtc:4852 TEST=voe_cmd_test R=henrika@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/343714eb06491b5c71867035f9ba10b4464283a8

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

minyue-webrtc

On 2015/07/21 07:45:16, braveyao1 wrote: > Hi, please help to take a look. Thanks. I ...

5 years, 5 months ago (2015-07-21 08:26:39 UTC) #3

braveyao1

5 years, 5 months ago (2015-07-21 10:28:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
343714eb06491b5c71867035f9ba10b4464283a8 (presubmit successful).