Issue 1248393003: Allow more than 2 input channels in AudioProcessing.

Issue 1248393003: Allow more than 2 input channels in AudioProcessing. (Closed)

Created:
5 years, 5 months ago by mgraczyk

Modified:
5 years, 5 months ago

Reviewers:
pbos-webrtc, aluebs-webrtc

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, aluebs-webrtc, bjornv1

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Allow more than 2 input channels in AudioProcessing. The number of output channels is constrained to be equal to either 1 or the number of input channels. An earlier version of this commit caused a crash on AEC dump. TBR=aluebs@webrtc.org,pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/86c6d33aec684d08189d498912e47cbc17c4d2db

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+708 lines, -371 lines)			Patch
M	talk/media/webrtc/fakewebrtcvoiceengine.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	webrtc/common_audio/audio_util.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webrtc/common_audio/audio_util_unittest.cc	View	6 chunks	+131 lines, -17 lines	0 comments	Download
M	webrtc/common_audio/include/audio_util.h	View	6 chunks	+67 lines, -12 lines	0 comments	Download
M	webrtc/common_audio/wav_file.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	webrtc/modules/audio_processing/audio_buffer.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	webrtc/modules/audio_processing/audio_buffer.cc	View	7 chunks	+28 lines, -60 lines	0 comments	Download
M	webrtc/modules/audio_processing/audio_processing_impl.h	View	6 chunks	+18 lines, -55 lines	0 comments	Download
M	webrtc/modules/audio_processing/audio_processing_impl.cc	View	30 chunks	+214 lines, -179 lines	1 comment	Download
M	webrtc/modules/audio_processing/include/audio_processing.h	View	8 chunks	+134 lines, -6 lines	0 comments	Download
M	webrtc/modules/audio_processing/include/mock_audio_processing.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/audio_processing_unittest.cc	View	4 chunks	+77 lines, -23 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/audioproc_float.cc	View	2 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mgraczyk

Committed patchset #1 (id:1) manually as 86c6d33aec684d08189d498912e47cbc17c4d2db (presubmit successful).

5 years, 5 months ago (2015-07-23 18:41:50 UTC) #1

aluebs-webrtc

lgtm Could you add a comment here of what caused the crash earlier and how ...

5 years, 5 months ago (2015-07-23 18:49:14 UTC) #2

mgraczyk

5 years, 5 months ago (2015-07-23 20:59:35 UTC) #3

Message was sent while issue was closed.

Yes, comment added.

https://codereview.webrtc.org/1248393003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1248393003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:545: sizeof(float) *
api_format_.output_stream().num_frames();
The previous version of this commit incorrectly used the frame and channel
counts from input_stream here.

Expand Messages | Collapse Messages