Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: webrtc/base/asynctcpsocket.cc

Issue 1247573002: Fix a Turn TCP port issue. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/turnport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/asynctcpsocket.cc
diff --git a/webrtc/base/asynctcpsocket.cc b/webrtc/base/asynctcpsocket.cc
index 0f7abd5a6cf142d002174656560a13fdd3b46433..97d1e171761dfcd9eb2a1a4724ffa24516a525d9 100644
--- a/webrtc/base/asynctcpsocket.cc
+++ b/webrtc/base/asynctcpsocket.cc
@@ -127,10 +127,11 @@ void AsyncTCPSocketBase::SetError(int error) {
int AsyncTCPSocketBase::SendTo(const void *pv, size_t cb,
const SocketAddress& addr,
const rtc::PacketOptions& options) {
- if (addr == GetRemoteAddress())
+ const SocketAddress& remote_address = GetRemoteAddress();
+ if (addr == remote_address)
return Send(pv, cb, options);
-
- ASSERT(false);
+ // Remote address may be empty if there is a sudden network change.
+ ASSERT(remote_address.IsNil());
socket_->SetError(ENOTCONN);
return -1;
}
« no previous file with comments | « no previous file | webrtc/p2p/base/turnport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698