Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1247443005: Revert of Fixing scenario where track is rejected and later un-rejected. (Closed)

Created:
5 years, 5 months ago by magjed_webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fixing scenario where track is rejected and later un-rejected. (patchset #5 id:80001 of https://codereview.webrtc.org/1231613002/) Reason for revert: I think this causes WebRtcBrowserTest.CallAndModifyStream to fail on Android. See https://code.google.com/p/webrtc/issues/detail?id=4857 for more info. Original issue's description: > Fixing scenario where track is rejected and later un-rejected. > > Added `RestartLocalTracks` and `RestartRemoteTracks` methods to > `MediaStreamHandlerContainer` which will redo the track handlers' > initial setup; most importantly, this will re-connect the > renderer/capturer/etc. to a channel which was destroyed and then > re-created. > > Also added `AcceptRemoteTracks` method to MediaStreamSignaling, which > does the inverse of `RejectRemoteTracks`. Effectively this will notify > sinks that the track is live again, after previously being set to > `kEnded` when it was rejected. > > BUG=webrtc:2136 > > Committed: https://crrev.com/be37888b6d5d269dbd5385569dba15c0d70594f2 > Cr-Commit-Position: refs/heads/master@{#9600} TBR=pthatcher@webrtc.org,juberti@webrtc.org,deadbeef@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2136, webrtc:4857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -113 lines) Patch
M talk/app/webrtc/mediastreamhandler.h View 10 chunks +1 line, -17 lines 0 comments Download
M talk/app/webrtc/mediastreamhandler.cc View 9 chunks +12 lines, -54 lines 0 comments Download
M talk/app/webrtc/mediastreamsignaling.h View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/mediastreamsignaling.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
Created Revert of Fixing scenario where track is rejected and later un-rejected.
5 years, 5 months ago (2015-07-23 13:02:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247443005/1
5 years, 5 months ago (2015-07-23 13:02:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 13:02:42 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 13:02:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66f438f8c37165db669e15314cdb7bbfa0841f4c
Cr-Commit-Position: refs/heads/master@{#9622}

Powered by Google App Engine
This is Rietveld 408576698