Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 1247033006: Configure AudioProcessing directly in agc_harness. (Closed)

Created:
5 years, 5 months ago by Andrew MacDonald
Modified:
5 years, 5 months ago
Reviewers:
ekm, aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Configure AudioProcessing directly in agc_harness. This allows us to configure create-time parameters for AudioProcessing in a voice engine app and avoid the onerous SetExtraOptions. voe_cmd_test would require significant refactoring to do the same. Minor cleanups: - Use agc_manager_direct. This should allow us to remove agc_manager. - Use CHECKs rather than ASSERTs. Committed: https://crrev.com/0b6a204b21b1360950593dcc80dc49682d637109 Cr-Commit-Position: refs/heads/master@{#9618}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -67 lines) Patch
M webrtc/tools/agc/agc_harness.cc View 1 9 chunks +66 lines, -67 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Andrew MacDonald
5 years, 5 months ago (2015-07-22 02:07:30 UTC) #2
ekm
lgtm. Nice, this should be useful at least for sanity checks for intelligibility as well.
5 years, 5 months ago (2015-07-22 18:59:43 UTC) #3
aluebs-webrtc
lgtm I am working on a CL fro deprecating AgcManager and just stopped when modifying ...
5 years, 5 months ago (2015-07-22 23:22:05 UTC) #4
Andrew MacDonald
On 2015/07/22 23:22:05, aluebs-webrtc wrote: > lgtm > > I am working on a CL ...
5 years, 5 months ago (2015-07-23 00:56:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247033006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247033006/20001
5 years, 5 months ago (2015-07-23 00:58:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 01:27:16 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 01:27:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b6a204b21b1360950593dcc80dc49682d637109
Cr-Commit-Position: refs/heads/master@{#9618}

Powered by Google App Engine
This is Rietveld 408576698