Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: webrtc/p2p/base/transportchannel.h

Issue 1246913005: TransportController refactoring (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Merging again Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/transportchannel.h
diff --git a/webrtc/p2p/base/transportchannel.h b/webrtc/p2p/base/transportchannel.h
index 15b38eee84b34497546f0a8a093e18ef4199aeb1..88cb335dcb8f2b06227054d94ad6eb08a95b11d5 100644
--- a/webrtc/p2p/base/transportchannel.h
+++ b/webrtc/p2p/base/transportchannel.h
@@ -37,16 +37,23 @@ enum PacketFlags {
};
// Used to indicate channel's connection state.
-enum TransportChannelState { STATE_CONNECTING, STATE_COMPLETED, STATE_FAILED };
+enum TransportChannelState {
+ STATE_INIT,
+ STATE_CONNECTING, // Will enter this state once a connection is created
+ STATE_COMPLETED,
+ STATE_FAILED
+};
// A TransportChannel represents one logical stream of packets that are sent
// between the two sides of a session.
class TransportChannel : public sigslot::has_slots<> {
public:
- explicit TransportChannel(const std::string& content_name, int component)
- : content_name_(content_name),
+ explicit TransportChannel(const std::string& transport_name, int component)
+ : transport_name_(transport_name),
component_(component),
- readable_(false), writable_(false), receiving_(false) {}
+ readable_(false),
+ writable_(false),
+ receiving_(false) {}
virtual ~TransportChannel() {}
// TODO(guoweis) - Make this pure virtual once all subclasses of
@@ -59,7 +66,7 @@ class TransportChannel : public sigslot::has_slots<> {
// Returns the session id of this channel.
virtual const std::string SessionId() const { return std::string(); }
- const std::string& content_name() const { return content_name_; }
+ const std::string& transport_name() const { return transport_name_; }
int component() const { return component_; }
// Returns the readable and states of this channel. Each time one of these
@@ -147,10 +154,9 @@ class TransportChannel : public sigslot::has_slots<> {
// Sets the receiving state, signaling if necessary.
void set_receiving(bool receiving);
-
private:
// Used mostly for debugging.
- std::string content_name_;
+ std::string transport_name_;
int component_;
bool readable_;
bool writable_;

Powered by Google App Engine
This is Rietveld 408576698