TransportController refactoring

webrtc/p2p/base/transportchannel.h

Index: webrtc/p2p/base/transportchannel.h
diff --git a/webrtc/p2p/base/transportchannel.h b/webrtc/p2p/base/transportchannel.h
index 15b38eee84b34497546f0a8a093e18ef4199aeb1..bd96781d292ebf9037761cd2acafc9aba80402c7 100644
--- a/webrtc/p2p/base/transportchannel.h
+++ b/webrtc/p2p/base/transportchannel.h
@@ -37,7 +37,12 @@ enum PacketFlags {
 };
 
 // Used to indicate channel's connection state.
-enum TransportChannelState { STATE_CONNECTING, STATE_COMPLETED, STATE_FAILED };
+enum TransportChannelState {
+  STATE_NEW,

[pthatcher1, 2015/08/25 18:40:39]

We usually use the name STATE_INIT for states like this (the external API names
of "new" is a little different).

[Taylor Brandstetter, 2015/08/25 20:39:55]

Done.

+  STATE_CONNECTING,

[pthatcher1, 2015/08/25 18:40:39]

Can you comment here when we'd be NEW but not CONNECTING?  Basically, before
SetLocalDescription is called?

[Taylor Brandstetter, 2015/08/25 20:39:55]

Done.

+  STATE_COMPLETED,
+  STATE_FAILED
+};
 
 // A TransportChannel represents one logical stream of packets that are sent
 // between the two sides of a session.
@@ -147,7 +152,6 @@ class TransportChannel : public sigslot::has_slots<> {
   // Sets the receiving state, signaling if necessary.
   void set_receiving(bool receiving);
 
-
  private:
   // Used mostly for debugging.
   std::string content_name_;