Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: webrtc/p2p/base/rawtransportchannel.h

Issue 1246913005: TransportController refactoring (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Set media engine on voice channel Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/rawtransportchannel.h
diff --git a/webrtc/p2p/base/rawtransportchannel.h b/webrtc/p2p/base/rawtransportchannel.h
index 75b494e65a0f1818753fdff657af09d1677e4403..800556bf8545881b26976f38ac6daba206604f9b 100644
--- a/webrtc/p2p/base/rawtransportchannel.h
+++ b/webrtc/p2p/base/rawtransportchannel.h
@@ -20,10 +20,6 @@
#if defined(FEATURE_ENABLE_PSTN)
-namespace rtc {
-class Thread;
-}
-
namespace cricket {
class Connection;
@@ -36,14 +32,12 @@ class StunPort;
// Implements a channel that just sends bare packets once we have received the
// address of the other side. We pick a single address to send them based on
// a simple investigation of NAT type.
-class RawTransportChannel : public TransportChannelImpl,
- public rtc::MessageHandler {
+class RawTransportChannel : public TransportChannelImpl {
public:
RawTransportChannel(const std::string& content_name,
int component,
RawTransport* transport,
- rtc::Thread *worker_thread,
- PortAllocator *allocator);
+ PortAllocator* allocator);
virtual ~RawTransportChannel();
// Implementation of normal channel packet sending.
@@ -68,12 +62,11 @@ class RawTransportChannel : public TransportChannelImpl,
// SignalAvailableCandidate once we have decided.
virtual void Connect();
+ virtual GatheringState gathering_state() const { return kGatheringNew; }
+
// Resets state back to unconnected.
virtual void Reset();
- // We don't actually worry about signaling since we can't send new candidates.
- virtual void OnSignalingReady() {}
-
// Handles a message setting the remote address. We are writable once we
// have this since we now know where to send.
virtual void OnCandidate(const Candidate& candidate);
@@ -160,7 +153,6 @@ class RawTransportChannel : public TransportChannelImpl,
private:
RawTransport* raw_transport_;
- rtc::Thread *worker_thread_;
PortAllocator* allocator_;
PortAllocatorSession* allocator_session_;
StunPort* stun_port_;
@@ -188,8 +180,7 @@ class RawTransportChannel : public TransportChannelImpl,
void OnReadPacket(PortInterface* port, const char* data, size_t size,
const rtc::SocketAddress& addr);
- // Handles a message to destroy unused ports.
- virtual void OnMessage(rtc::Message *msg);
+ void DestroyUnusedPorts();
DISALLOW_COPY_AND_ASSIGN(RawTransportChannel);
};

Powered by Google App Engine
This is Rietveld 408576698