Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: webrtc/p2p/base/p2ptransport.h

Issue 1246913005: TransportController refactoring (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: minor cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/p2ptransport.h
diff --git a/webrtc/p2p/base/p2ptransport.h b/webrtc/p2p/base/p2ptransport.h
index 34cc8491a92719daa62a61785883add07e66d7c3..094fd7113ea8e5ca095d1d4c89a2071255bfd44f 100644
--- a/webrtc/p2p/base/p2ptransport.h
+++ b/webrtc/p2p/base/p2ptransport.h
@@ -18,9 +18,7 @@ namespace cricket {
class P2PTransport : public Transport {
public:
- P2PTransport(rtc::Thread* signaling_thread,
- rtc::Thread* worker_thread,
- const std::string& content_name,
+ P2PTransport(const std::string& content_name,
pthatcher1 2015/08/10 20:40:17 Again, can you comment that everything should be c
Taylor Brandstetter 2015/08/11 01:20:07 Done.
PortAllocator* allocator);
virtual ~P2PTransport();
@@ -31,6 +29,7 @@ class P2PTransport : public Transport {
friend class P2PTransportChannel;
+ private:
DISALLOW_COPY_AND_ASSIGN(P2PTransport);
pthatcher1 2015/08/10 20:40:17 Why is this private?
Taylor Brandstetter 2015/08/11 01:20:07 DISALLOW_COPY_AND_ASSIGN needs to be in the privat
};

Powered by Google App Engine
This is Rietveld 408576698