components/filesystem/file_impl.cc - Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/file_impl.cc

Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/file_impl.cc

diff --git a/components/filesystem/file_impl.cc b/components/filesystem/file_impl.cc

index 25394989477ad5a8641706d67f91a7f6724bf06e..4925f9acaec5bd574ec9ec86af782d47f90ee70c 100644

--- a/components/filesystem/file_impl.cc

+++ b/components/filesystem/file_impl.cc

@@ -102,7 +102,7 @@ void FileImpl::Write(mojo::Array<uint8_t> bytes_to_write,

// actually wrote that much).

if (bytes_to_write.size() >

#if defined(OS_WIN)

- std::numeric_limits<INT>::max()) {

+ static_cast<size_t>(std::numeric_limits<int>::max())) {

#else

static_cast<size_t>(std::numeric_limits<ssize_t>::max())) {

#endif

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/leveldatabase/BUILD.gn » ('j') | no next file with comments »