Implement store as an explicit atomic operation.

webrtc/video/video_capture_input.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 45 matching lines @@
                                                  stats_proxy)) {
   capture_thread_->Start();
   capture_thread_->SetPriority(kHighPriority);
   module_process_thread_->RegisterModule(overuse_detector_.get());
 }
 
 VideoCaptureInput::~VideoCaptureInput() {
   module_process_thread_->DeRegisterModule(overuse_detector_.get());
 
   // Stop the thread.
   rtc::AtomicOps::Increment(&stop_);

[Alexander Potapenko, 2015/07/22 13:43:00]

Isn't rtc::AtomicOps::ReleaseStore(&stop, 1) enough here?

[pbos-webrtc, 2015/07/22 13:51:04]

Done.

   capture_event_.Set();
 
   // Stop the camera input.
   capture_thread_->Stop();
   delete &capture_event_;
   delete &deliver_event_;
 }
 
 void VideoCaptureInput::IncomingCapturedFrame(const VideoFrame& video_frame) {
   // TODO(pbos): Remove local rendering, it should be handled by the client code
@@ skipping 44 matching lines @@
 }
 
 bool VideoCaptureInput::CaptureThreadFunction(void* obj) {
   return static_cast<VideoCaptureInput*>(obj)->CaptureProcess();
 }
 
 bool VideoCaptureInput::CaptureProcess() {
   static const int kThreadWaitTimeMs = 100;
   int64_t capture_time = -1;
   if (capture_event_.Wait(kThreadWaitTimeMs) == kEventSignaled) {
-    if (rtc::AtomicOps::Load(&stop_))
+    if (rtc::AtomicOps::AcquireLoad(&stop_))
       return false;
 
     int64_t encode_start_time = -1;
     VideoFrame deliver_frame;
     {
       CriticalSectionScoped cs(capture_cs_.get());
       if (!captured_frame_.IsZeroSize()) {
         deliver_frame = captured_frame_;
         captured_frame_.Reset();
       }
@@ skipping 11 matching lines @@
   }
   // We're done!
   if (capture_time != -1) {
     overuse_detector_->FrameSent(capture_time);
   }
   return true;
 }
 
 }  // namespace internal
 }  // namespace webrtc