webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc - Issue 1242043002: Selectable number of TL screenshare loopback test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Issue 1242043002: Selectable number of TL screenshare loopback test (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Updated test case Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc ('K') | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc ('k') | webrtc/video/screenshare_loopback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

index 198be2a09fb25465e361a105e64955837426c682..f4be01e72bc13c98f78d65b1e8738fd88787f1fc 100644

--- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

@@ -113,14 +113,14 @@ TEST_F(ScreenshareLayerTest, 1Layer) {

// One layer screenshare should not use the frame dropper as all frames will

// belong to the base layer.

flags = layers_->EncodeFlags(timestamp);

- EXPECT_EQ(0, flags);

+ EXPECT_EQ(ScreenshareLayers::kTl0Flags, flags);

layers_->PopulateCodecSpecific(false, &vp8_info, timestamp);

EXPECT_EQ(static_cast<uint8_t>(kNoTemporalIdx), vp8_info.temporalIdx);

EXPECT_FALSE(vp8_info.layerSync);

EXPECT_EQ(kNoTl0PicIdx, vp8_info.tl0PicIdx);

layers_->FrameEncoded(frame_size_, timestamp, kDefaultQp);

flags = layers_->EncodeFlags(timestamp);

- EXPECT_EQ(0, flags);

+ EXPECT_EQ(ScreenshareLayers::kTl0Flags, flags);

timestamp += kTimestampDelta5Fps;

layers_->PopulateCodecSpecific(false, &vp8_info, timestamp);

EXPECT_EQ(static_cast<uint8_t>(kNoTemporalIdx), vp8_info.temporalIdx);