talk/media/webrtc/webrtcvideocapturer.cc - Issue 1241973002: Use std::string references instead of copying contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideocapturer.cc

Issue 1241973002: Use std::string references instead of copying contents. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix use-after-free Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/media/webrtc/webrtcvideocapturer.cc

diff --git a/talk/media/webrtc/webrtcvideocapturer.cc b/talk/media/webrtc/webrtcvideocapturer.cc

index f8c373db36b3048e458ff58d2e3ecc7d80ca5031..8ef920e98a3346bc552c72cd357d418d79a3c695 100644

--- a/talk/media/webrtc/webrtcvideocapturer.cc

+++ b/talk/media/webrtc/webrtcvideocapturer.cc

@@ -265,7 +265,7 @@ bool WebRtcVideoCapturer::SetApplyRotation(bool enable) {

// calls, can't take lock.

DCHECK(module_);

- const std::string group_name =

+ const std::string& group_name =

webrtc::field_trial::FindFullName("WebRTC-CVO");

if (group_name == "Disabled") {

« no previous file with comments | « talk/app/webrtc/webrtcsdp.cc ('k') | talk/media/webrtc/webrtcvideoengine2.cc » ('j') | no next file with comments »