talk/app/webrtc/jsepsessiondescription.cc - Issue 1241973002: Use std::string references instead of copying contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/jsepsessiondescription.cc

Issue 1241973002: Use std::string references instead of copying contents. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix use-after-free Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/jsepsessiondescription.cc

diff --git a/talk/app/webrtc/jsepsessiondescription.cc b/talk/app/webrtc/jsepsessiondescription.cc

index 697f332c27c64274951ba4255273c97568dcf09b..d1428d000cc060f05173eef3651866428a653171 100644

--- a/talk/app/webrtc/jsepsessiondescription.cc

+++ b/talk/app/webrtc/jsepsessiondescription.cc

@@ -130,7 +130,7 @@ bool JsepSessionDescription::AddCandidate(

}

if (mediasection_index >= number_of_mediasections())

return false;

- const std::string content_name =

+ const std::string& content_name =

description_->contents()[mediasection_index].name;

const cricket::TransportInfo* transport_info =

description_->GetTransportInfoByName(content_name);

« no previous file with comments | « no previous file | talk/app/webrtc/webrtcsdp.cc » ('j') | no next file with comments »