Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241283004: iOS: Move AppRTC logging methods to public headers. (Closed)

Created:
5 years, 5 months ago by tkchin_webrtc
Modified:
5 years, 5 months ago
Reviewers:
jiayl2, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Move AppRTC logging methods to public headers. BUG= Committed: https://crrev.com/c3f46a9f7fe4536877e7b5f6af109dbdc08b8242 Cr-Commit-Position: refs/heads/master@{#9629}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -272 lines) Patch
A + talk/app/webrtc/objc/RTCLogging.mm View 1 1 chunk +22 lines, -26 lines 0 comments Download
A + talk/app/webrtc/objc/public/RTCLogging.h View 1 chunk +38 lines, -34 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ARDAppClient.m View 8 chunks +13 lines, -13 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ARDAppEngineClient.m View 4 chunks +7 lines, -6 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ARDSDPUtils.m View 3 chunks +4 lines, -4 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m View 3 chunks +4 lines, -3 lines 2 comments Download
M talk/examples/objc/AppRTCDemo/ARDWebSocketChannel.m View 8 chunks +14 lines, -13 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/RTCICECandidate+JSON.m View 2 chunks +2 lines, -2 lines 0 comments Download
D talk/examples/objc/AppRTCDemo/common/ARDLogging.h View 1 chunk +0 lines, -88 lines 0 comments Download
D talk/examples/objc/AppRTCDemo/common/ARDLogging.mm View 1 chunk +0 lines, -68 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/common/ARDUtilities.m View 5 chunks +6 lines, -5 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m View 1 2 chunks +11 lines, -3 lines 0 comments Download
M talk/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m View 3 chunks +5 lines, -5 lines 0 comments Download
M talk/libjingle.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/libjingle_examples.gyp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tkchin_webrtc
5 years, 5 months ago (2015-07-22 22:47:46 UTC) #3
Chuck
LGTM https://codereview.webrtc.org/1241283004/diff/40001/talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m File talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right): https://codereview.webrtc.org/1241283004/diff/40001/talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m#newcode30 talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m:30: #import "RTCLogging.h" Should this be grouped with the ...
5 years, 5 months ago (2015-07-23 18:21:45 UTC) #4
tkchin_webrtc
https://codereview.webrtc.org/1241283004/diff/40001/talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m File talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right): https://codereview.webrtc.org/1241283004/diff/40001/talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m#newcode30 talk/examples/objc/AppRTCDemo/ARDSignalingMessage.m:30: #import "RTCLogging.h" On 2015/07/23 18:21:45, Chuck wrote: > Should ...
5 years, 5 months ago (2015-07-23 18:30:00 UTC) #5
jiayl2
rubber stamp lgtm
5 years, 5 months ago (2015-07-23 18:33:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241283004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1241283004/40001
5 years, 5 months ago (2015-07-23 18:49:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-23 19:50:59 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 19:51:06 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c3f46a9f7fe4536877e7b5f6af109dbdc08b8242
Cr-Commit-Position: refs/heads/master@{#9629}

Powered by Google App Engine
This is Rietveld 408576698