Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241123002: Remove UpdateSsrcs from EncoderStateFeedback. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove UpdateSsrcs from EncoderStateFeedback. Removes ability to modify set SSRCs from EncoderStateFeedback after construction. BUG=webrtc:1695 R=sprang@webrtc.org TBR=stefan@webrtc.org Committed: https://crrev.com/8ff04d6b3b9a2fc28394ef6ad77201a1443e24c8 Cr-Commit-Position: refs/heads/master@{#9603}

Patch Set 1 #

Total comments: 2

Patch Set 2 : empty SSRC vector handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -58 lines) Patch
M webrtc/video/call.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback.cc View 1 chunk +3 lines, -21 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-20 12:59:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241123002/1
5 years, 5 months ago (2015-07-20 12:59:50 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1241123002/diff/1/webrtc/video/call.cc File webrtc/video/call.cc (right): https://codereview.webrtc.org/1241123002/diff/1/webrtc/video/call.cc#newcode186 webrtc/video/call.cc:186: This will create a channel with an encoder with ...
5 years, 5 months ago (2015-07-20 13:45:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 13:52:25 UTC) #6
pbos-webrtc
https://codereview.webrtc.org/1241123002/diff/1/webrtc/video/call.cc File webrtc/video/call.cc (right): https://codereview.webrtc.org/1241123002/diff/1/webrtc/video/call.cc#newcode186 webrtc/video/call.cc:186: On 2015/07/20 13:45:22, språng wrote: > This will create ...
5 years, 5 months ago (2015-07-20 13:59:04 UTC) #7
sprang_webrtc
lgtm
5 years, 5 months ago (2015-07-20 14:02:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241123002/20001
5 years, 5 months ago (2015-07-20 14:05:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/211)
5 years, 5 months ago (2015-07-20 14:06:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241123002/20001
5 years, 5 months ago (2015-07-20 14:09:40 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-20 15:01:21 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 15:01:34 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ff04d6b3b9a2fc28394ef6ad77201a1443e24c8
Cr-Commit-Position: refs/heads/master@{#9603}

Powered by Google App Engine
This is Rietveld 408576698