Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1238943003: Don't use result of "field_trial::FindFullName" as string reference. (Closed)

Created:
5 years, 5 months ago by joachim
Modified:
5 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't use result of "field_trial::FindFullName" as string reference. "field_trial::FindFullName" can return "std::string()" which should not be referenced by the caller. Committed: https://crrev.com/bd3842808996dbb85007242214352f1e6ebd3d17 Cr-Commit-Position: refs/heads/master@{#9594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M talk/media/webrtc/webrtcvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
joachim
ptal, this addresses the potential problem you found in https://codereview.webrtc.org/1241973002/
5 years, 5 months ago (2015-07-16 10:03:15 UTC) #2
pthatcher1
lgtm
5 years, 5 months ago (2015-07-16 10:06:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238943003/1
5 years, 5 months ago (2015-07-16 10:07:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 11:06:05 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 11:06:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd3842808996dbb85007242214352f1e6ebd3d17
Cr-Commit-Position: refs/heads/master@{#9594}

Powered by Google App Engine
This is Rietveld 408576698