webrtc/modules/video_coding/main/source/session_info.cc - Issue 1238033003: Prevent OOB reads for truncated H264 STAP-A packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/session_info.cc

Issue 1238033003: Prevent OOB reads for truncated H264 STAP-A packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: added logging + todos Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/video_coding/main/source/session_info.cc

diff --git a/webrtc/modules/video_coding/main/source/session_info.cc b/webrtc/modules/video_coding/main/source/session_info.cc

index 8eba432643ce0164614f9bc82c412c399efbeaaa..49839e5dff3ce575aaddb1643291ba5c7d1f1f44 100644

--- a/webrtc/modules/video_coding/main/source/session_info.cc

+++ b/webrtc/modules/video_coding/main/source/session_info.cc

@@ -133,6 +133,8 @@ size_t VCMSessionInfo::InsertBuffer(uint8_t* frame_buffer,

// We handle H.264 STAP-A packets in a special way as we need to remove the

// two length bytes between each NAL unit, and potentially add start codes.

+ // TODO(pbos): Remove H264 parsing from this step and use a fragmentation

+ // header supplied by the H264 depacketizer.

const size_t kH264NALHeaderLengthInBytes = 1;

const size_t kLengthFieldLength = 2;

if (packet.codecSpecificHeader.codec == kRtpVideoH264 &&

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc ('k') | webrtc/test/call_test.cc » ('j') | no next file with comments »