Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: webrtc/modules/video_coding/main/source/session_info_unittest.cc

Issue 1238033003: Prevent OOB reads for truncated H264 STAP-A packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/main/source/session_info_unittest.cc
diff --git a/webrtc/modules/video_coding/main/source/session_info_unittest.cc b/webrtc/modules/video_coding/main/source/session_info_unittest.cc
index fae55f425295fab1acb29cec780b43cead96ac8f..76f34407346844eefc86c9392041652e5a6dcaa5 100644
--- a/webrtc/modules/video_coding/main/source/session_info_unittest.cc
+++ b/webrtc/modules/video_coding/main/source/session_info_unittest.cc
@@ -1061,4 +1061,14 @@ TEST_F(TestNalUnits, ReorderWrapLosses) {
EXPECT_EQ(0U, session_.SessionLength());
}
+TEST_F(TestNalUnits, SurvivesIncorrectH264StapALength) {
+ packet_.codecSpecificHeader.codec = kRtpVideoH264;
+ packet_.codecSpecificHeader.codecHeader.H264.packetization_type = kH264StapA;
+ const uint8_t kPacket[] = {120, 16, 129, 58};
+ packet_.dataPtr = kPacket;
+ packet_.sizeBytes = sizeof(kPacket);
+ EXPECT_EQ(kSizeError, session_.InsertPacket(packet_, frame_buffer_, kNoErrors,
+ frame_data));
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698