Modified histogram shell plot script, added python dynamics plot script

Renamed bwe_plot.sh to plot_dynamics.sh

Added histogram shell plot script
Added python dynamics plot script


Supports:

- plot_bars.sh
---- Histogram plots
---- Baseline histograms
---- Vertical error lines
---- Dashed horizontal lines
---- Different colors for different algorithms
---- Legends read as input
---- Extra horizontal space in case there are TCP flows plotted
---- Multiple windows
---- Auto vertical scale, except for latency plots which are kept constant for all plots


- plot_dynamics.py
---- Dynamic plots
---- Different colors for different flows and algorithms
---- Dashed line plot for available capacity
---- Throughput, latency and loss on separated boxes

R=stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f24b2bc48ca0e62194d6a1bdb1cacd37c4d0a635

[magalhaesc, 2015-07-16 10:01:34]

magalhaesc@google.com changed reviewers:
+ stefan@webrtc.org

[magalhaesc, 2015-07-16 11:28:53]

Modified histogram shell plot script, added python dynamics plot script.

[stefan-webrtc, 2015-07-21 12:16:37]

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh (right):

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh:236: color=18 # Gray.
Two spaces before a comment. See other comments as well

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh:288: (( $(bc <<<
"$x_error_line+$box_width>$x_start+1.5+0.5*$tcp_space") \
Spaces infront of and after operators. If possible... :)

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right):

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:72: print "alg %s:
%d" % (alg, len(v._samples[alg]))
Can probably be moved

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:126: #('offset',
"Time (s)", "Offset (ms)", 3),
This should be cleaned up

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:148:
#fig.suptitle(test_name)
Remove?

[magalhaesc, 2015-07-21 17:04:06]

Split bwe_plot.sh, comments addressed

[magalhaesc, 2015-07-21 17:05:03]

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh (right):

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh:236: color=18 # Gray.
On 2015/07/21 12:16:36, stefan-webrtc (holmer) wrote:
> Two spaces before a comment. See other comments as well

Done.

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/bwe_plot.sh:288: (( $(bc <<<
"$x_error_line+$box_width>$x_start+1.5+0.5*$tcp_space") \
On 2015/07/21 12:16:36, stefan-webrtc (holmer) wrote:
> Spaces infront of and after operators. If possible... :)

Done.

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right):

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:72: print "alg %s:
%d" % (alg, len(v._samples[alg]))
On 2015/07/21 12:16:37, stefan-webrtc (holmer) wrote:
> Can probably be moved

Done.

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:126: #('offset',
"Time (s)", "Offset (ms)", 3),
On 2015/07/21 12:16:37, stefan-webrtc (holmer) wrote:
> This should be cleaned up

Done.

https://codereview.webrtc.org/1237903003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:148:
#fig.suptitle(test_name)
On 2015/07/21 12:16:37, stefan-webrtc (holmer) wrote:
> Remove?

Done.

[magalhaesc, 2015-07-21 17:11:25]

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh (right):

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh:30: colors=(a7001f
0a60c2 b2582b 21a66c d6604d 4393c3 f4a582 92c5de edcbb7 b1c5d0)
Added back space before "colors"

[magalhaesc, 2015-07-21 19:02:19]

Thanks for the review,
comments addressed.

[stefan-webrtc, 2015-07-22 09:32:03]

Thanks for splitting the bwe_plot.sh into two files. A LOT better :)

lgtm

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right):

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:113: legend =
plt.legend(loc='upper right', shadow=True, fontsize='large',
ncol=len(v._samples))
Can you make this line 80 characters?

[magalhaesc, 2015-07-22 12:53:05]

Comments addressed [2]

[magalhaesc, 2015-07-22 12:54:41]

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right):

https://codereview.webrtc.org/1237903003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:113: legend =
plt.legend(loc='upper right', shadow=True, fontsize='large',
ncol=len(v._samples))
On 2015/07/22 09:32:03, stefan-webrtc (holmer) wrote:
> Can you make this line 80 characters?

Done.

[magalhaesc, 2015-07-22 15:40:42]

Rebased

[magalhaesc, 2015-07-22 15:41:19]

Committed patchset #4 (id:60001) manually as
f24b2bc48ca0e62194d6a1bdb1cacd37c4d0a635.