Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc

Issue 1237393002: Evaluation tests (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comments addressed [3] Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc b/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc
index c9033c564f473698d97d2344426357fefc5bb3b3..90554a329433a15f92d0797a1c0a8950cdcee7a0 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc
@@ -302,7 +302,7 @@ double MetricRecorder::ObjectiveFunction() {
void MetricRecorder::PlotThroughputHistogram(const std::string& title,
const std::string& bwe_name,
- int num_flows,
+ size_t num_flows,
int64_t extra_offset_ms,
const std::string optimum_id) {
size_t num_packets_received = delays_ms_.size();
@@ -347,14 +347,14 @@ void MetricRecorder::PlotThroughputHistogram(const std::string& title,
void MetricRecorder::PlotThroughputHistogram(const std::string& title,
const std::string& bwe_name,
- int num_flows,
+ size_t num_flows,
int64_t extra_offset_ms) {
PlotThroughputHistogram(title, bwe_name, num_flows, extra_offset_ms, "");
}
void MetricRecorder::PlotDelayHistogram(const std::string& title,
const std::string& bwe_name,
- int num_flows,
+ size_t num_flows,
int64_t one_way_path_delay_ms) {
size_t num_packets_received = delays_ms_.size();
double average_delay_ms = Average(delays_ms_, num_packets_received);
@@ -395,7 +395,7 @@ void MetricRecorder::PlotDelayHistogram(const std::string& title,
void MetricRecorder::PlotLossHistogram(const std::string& title,
const std::string& bwe_name,
- int num_flows,
+ size_t num_flows,
float global_loss_ratio) {
BWE_TEST_LOGGING_LABEL(6, title, "packet_loss_ratio_(%)", num_flows)
BWE_TEST_LOGGING_BAR(6, bwe_name, 100.0f * global_loss_ratio, flow_id_);
@@ -406,7 +406,7 @@ void MetricRecorder::PlotLossHistogram(const std::string& title,
void MetricRecorder::PlotObjectiveHistogram(const std::string& title,
const std::string& bwe_name,
- int num_flows) {
+ size_t num_flows) {
BWE_TEST_LOGGING_LABEL(7, title, "objective_function", num_flows)
BWE_TEST_LOGGING_BAR(7, bwe_name, ObjectiveFunction(), flow_id_);
}
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698