Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Issue 1237233003: Avoids error message about unknown selected data source for Port iPhone Microphone (Closed)

Created:
5 years, 5 months ago by henrika_webrtc
Modified:
5 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoids error message about unknown selected data source for Port iPhone Microphone TBR=tkchin BUG=webrtc:4845 TEST=modules_unittests Committed: https://chromium.googlesource.com/external/webrtc/+/324d9c9a86e2fa331234eb0fa227845fde9f0317

Patch Set 1 #

Patch Set 2 : Removed extra logging #

Patch Set 3 : nit #

Total comments: 1

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 2 5 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika_webrtc
Fixing an issue that was added by me in my previous CL where I deactivated ...
5 years, 5 months ago (2015-07-17 10:56:07 UTC) #2
henrika_webrtc
tkchin@ please check this CL. https://codereview.webrtc.org/1237233003/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.mm File webrtc/modules/audio_device/ios/audio_device_ios.mm (left): https://codereview.webrtc.org/1237233003/diff/40001/webrtc/modules/audio_device/ios/audio_device_ios.mm#oldcode669 webrtc/modules/audio_device/ios/audio_device_ios.mm:669: // Deactivate the audio ...
5 years, 5 months ago (2015-07-17 10:58:44 UTC) #3
henrika_webrtc
Landing with tkchin@ as TBR since this is such a fundamental issue where we currently ...
5 years, 5 months ago (2015-07-20 11:08:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237233003/60001
5 years, 5 months ago (2015-07-20 11:09:07 UTC) #6
henrika_webrtc
5 years, 5 months ago (2015-07-20 11:09:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
324d9c9a86e2fa331234eb0fa227845fde9f0317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698