Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1236383002: Ignore genperf lib in merge_libs.py. (Closed)

Created:
5 years, 5 months ago by noahric
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore genperf lib in merge_libs.py. It's built as a part of the chromium build(?), but causes problems with XCode 7's new bitcode intermediate format. It should really never been included, but it never caused link failures before. BUG= Committed: https://crrev.com/83d6b0c254429584e5779ee33382ec82d1306ef5 Cr-Commit-Position: refs/heads/master@{#9606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/build/merge_libs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
noahric
Justin: since everyone appears OOO, can you find someone to approve this? I'd normally send ...
5 years, 5 months ago (2015-07-15 18:56:11 UTC) #2
tkchin_webrtc
On 2015/07/15 18:56:11, noahric wrote: > Justin: since everyone appears OOO, can you find someone ...
5 years, 5 months ago (2015-07-18 02:00:21 UTC) #4
Andrew MacDonald
lgtm
5 years, 5 months ago (2015-07-21 19:06:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236383002/1
5 years, 5 months ago (2015-07-21 19:09:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236383002/1
5 years, 5 months ago (2015-07-21 19:10:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:54:37 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:54:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83d6b0c254429584e5779ee33382ec82d1306ef5
Cr-Commit-Position: refs/heads/master@{#9606}

Powered by Google App Engine
This is Rietveld 408576698