talk/app/webrtc/peerconnectionendtoend_unittest.cc - Issue 1236023010: In PeerConnectionTestWrapper, put audio input on a separate thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectionendtoend_unittest.cc

Issue 1236023010: In PeerConnectionTestWrapper, put audio input on a separate thread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing potential deadlock in FakeAudioCaptureModule, caused by unnecessary call to Thread::Send Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/peerconnectionendtoend_unittest.cc

diff --git a/talk/app/webrtc/peerconnectionendtoend_unittest.cc b/talk/app/webrtc/peerconnectionendtoend_unittest.cc

index 7da7cc81398e02ac7c0bb60ee2155333ba98451a..7773a262002e215c1319681561da73e3225ef1ec 100644

--- a/talk/app/webrtc/peerconnectionendtoend_unittest.cc

+++ b/talk/app/webrtc/peerconnectionendtoend_unittest.cc

@@ -268,10 +268,6 @@ class PeerConnectionEndToEndTest

DataChannelList callee_signaled_data_channels_;

};

-// Disable for TSan v2, see

-// https://code.google.com/p/webrtc/issues/detail?id=1205 for details.

-#if !defined(THREAD_SANITIZER)

// Flaky on Windows. Disabled per issue 4464.

#ifdef WEBRTC_WIN

#define MAYBE_Call DISABLED_Call

@@ -427,4 +423,3 @@ TEST_F(PeerConnectionEndToEndTest,

EXPECT_EQ(1U, dc_1_observer->received_message_count());

EXPECT_EQ(1U, dc_2_observer->received_message_count());

}

-#endif // if !defined(THREAD_SANITIZER)

« no previous file with comments | « no previous file | talk/app/webrtc/test/fakeaudiocapturemodule.h » ('j') | talk/app/webrtc/test/peerconnectiontestwrapper.cc » ('J')