Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc

Issue 1235643003: Miscellaneous changes split from https://codereview.webrtc.org/1230503003 . (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: static_cast isn't C Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc
diff --git a/webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc b/webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc
index 2f1888d28cf27e169d6273e1145de20d40bc2a86..522f5e1e36d61d77ef59fc52823b9a58a7a90f97 100644
--- a/webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc
+++ b/webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc
@@ -33,9 +33,11 @@
using std::complex;
namespace webrtc {
+namespace {
-using webrtc::RealFourier;
-using webrtc::IntelligibilityEnhancer;
+bool ValidateClearWindow(const char* flagname, int32_t value) {
+ return value >= 0;
aluebs-webrtc 2015/07/16 21:03:40 Shouldn't this be >? I think it would be better if
ekm 2015/07/16 21:37:18 Yes, this should be >, since it will use arrays of
Peter Kasting 2015/07/17 00:05:14 Done.
+}
DEFINE_int32(clear_type,
webrtc::intelligibility::VarianceArray::kStepInfinite,
@@ -44,6 +46,8 @@ DEFINE_double(clear_alpha, 0.9, "Variance decay factor for clear data.");
DEFINE_int32(clear_window,
475,
"Window size for windowed variance for clear data.");
+const bool clear_window_dummy =
+ google::RegisterFlagValidator(&FLAGS_clear_window, &ValidateClearWindow);
DEFINE_int32(sample_rate,
16000,
"Audio sample rate used in the input and output files.");
@@ -137,6 +141,7 @@ void void_main(int argc, char* argv[]) {
}
}
+} // namespace
} // namespace webrtc
int main(int argc, char* argv[]) {

Powered by Google App Engine
This is Rietveld 408576698