Miscellaneous changes split from https://codereview.webrtc.org/1230503003 .

webrtc/modules/audio_coding/codecs/isac/main/source/isac.c

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 732 matching lines @@
   }
 
   /* Generate CRC if required. */
   if ((instISAC->bandwidthKHz != isac8kHz) && (streamLenUB > 0)) {
     uint32_t crc;
 
     WebRtcIsac_GetCrc((int16_t*)(&(encoded[streamLenLB + 1])),
                       streamLenUB + garbageLen, &crc);
 #ifndef WEBRTC_ARCH_BIG_ENDIAN
     for (k = 0; k < LEN_CHECK_SUM_WORD8; k++) {
-      encoded[streamLen - LEN_CHECK_SUM_WORD8 + k] = crc >> (24 - k * 8);
+      encoded[streamLen - LEN_CHECK_SUM_WORD8 + k] =
+          (crc >> (24 - k * 8)) & 0xFF;

[kwiberg-webrtc, 2015/07/12 18:40:30]

Why the explicit & 0xff?

[Peter Kasting, 2015/07/13 02:41:24]

It should probably be a static_cast<uint8_t>() instead, now that I think about
it.

The goal was to eliminate MSVC "implicit cast could have truncated value"
warnings by making the truncation explicit, but doing that with a cast is better
than doing it with a mask.

[Peter Kasting, 2015/07/13 22:25:04]

Changed to a static_cast.

[kwiberg-webrtc, 2015/07/15 01:10:53]

Excellent. (That you changed to a cast. A static_cast was maybe not such a good
idea... ;-) )

     }
 #else
     memcpy(&encoded[streamLenLB + streamLenUB + 1], &crc, LEN_CHECK_SUM_WORD8);
 #endif
   }
   return streamLen;
 }
 
 
 /******************************************************************************
@@ skipping 1628 matching lines @@
   WebRtcIsacBw_GetBandwidthInfo(&instISAC->bwestimator_obj,
                                 instISAC->decoderSamplingRateKHz, bwinfo);
 }
 
 void WebRtcIsac_SetBandwidthInfo(ISACStruct* inst,
                                  const IsacBandwidthInfo* bwinfo) {
   ISACMainStruct* instISAC = (ISACMainStruct*)inst;
   assert(instISAC->initFlag & BIT_MASK_ENC_INIT);
   WebRtcIsacBw_SetBandwidthInfo(&instISAC->bwestimator_obj, bwinfo);
 }